uProtocol Options Cleanup #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhartley
added
documentation
The following change addresses a number of concerns with the uprotocol_options.proto that is used to declare protocol specific metadata.
stevenhartley
force-pushed
the
uoptions_cleanup
branch
from
da4b6bf
to
9a34cb7
Compare
sophokles73
requested changes
May 17, 2024
|
|
||
| // Code Access Permission (CAP) Level for said topic | ||
| uint32 permission_level = 4; | ||
| } |
There was a problem hiding this comment.
done, thank you
Co-authored-by: Kai Hudalla <kai.hudalla@bosch.com>
Co-authored-by: Kai Hudalla <kai.hudalla@bosch.com>
|
changes have been reviewed by others internal to GM who are not setup with github. Please let me know @sophokles73 if you are OK that I merge the changes or you would like anything else updated. |
gregmedd
added a commit
to gregmedd/up-conan-recipes
that referenced
this pull request
May 23, 2024
The up-spec repo moved the core API proto files into a new v1 folder as part of eclipse-uprotocol/up-spec#141. With that change, we are no longer required to make our own v1 folder.
gregmedd
added a commit
to gregmedd/up-spec
that referenced
this pull request
May 23, 2024
The protobuf compiler uses the concept of a "canonical" path when
generating source files. This is the base point where it searches for
import files. It _expects_ that path will match the base path for
searching for headers, too. The end result is that
import "v1/ustatus.proto"
will generate a C++ header that contains
#include "v1/ustatus.pb.h"
while we have been explicitly asked to use includes starting with
`uprotocol` in up-cpp:
#include "uprotocol/v1/ustatus.pb.h"
We were able to work around this with some tricks when the import paths
were file names only (e.g. `import ustatus.proto`). However, the proto
files have moved under the `v1/` directory as of eclipse-uprotocol#141.
Based on my reading of the protoc documentation and several stack
overflow postings, it seems the intended way for .proto files to be
written in this scenario is to import the full canonical path as
intended for the output files:
import "uprotocol/v1/ustatus.proto"
so that protoc can generate the correct paths in output sources in the
first place.
gregmedd
added a commit
to gregmedd/up-spec
that referenced
this pull request
May 23, 2024
The protobuf compiler uses the concept of a "canonical" path when
generating source files. This is the base point where it searches for
import files. It _expects_ that path will match the base path for
searching for headers, too. The end result is that
import "v1/ustatus.proto"
will generate a C++ header that contains
#include "v1/ustatus.pb.h"
while we have been explicitly asked to use includes starting with
`uprotocol` in up-cpp:
#include "uprotocol/v1/ustatus.pb.h"
We were able to work around this with some tricks when the import paths
were file names only (e.g. `import ustatus.proto`). However, the proto
files have moved under the `v1/` directory as of eclipse-uprotocol#141.
Based on my reading of the protoc documentation and several stack
overflow postings, it seems the intended way for .proto files to be
written in this scenario is to import the full canonical path as
intended for the output files:
import "uprotocol/v1/ustatus.proto"
so that protoc can generate the correct paths in output sources in the
first place.
gregmedd
added a commit
to gregmedd/up-spec
that referenced
this pull request
May 23, 2024
The protobuf compiler uses the concept of a "canonical" path when
generating source files. This is the base point where it searches for
import files. It _expects_ that path will match the base path for
searching for headers, too. The end result is that
import "v1/ustatus.proto"
will generate a C++ header that contains
#include "v1/ustatus.pb.h"
while we have been explicitly asked to use includes starting with
`uprotocol` in up-cpp:
#include "uprotocol/v1/ustatus.pb.h"
We were able to work around this with some tricks when the import paths
were file names only (e.g. `import ustatus.proto`). However, the proto
files have moved under the `v1/` directory as of eclipse-uprotocol#141.
Based on my reading of the protoc documentation and several stack
overflow postings, it seems the intended way for .proto files to be
written in this scenario is to import the full canonical path as
intended for the output files:
import "uprotocol/v1/ustatus.proto"
so that protoc can generate the correct paths in output sources in the
first place.
gregmedd
added a commit
to gregmedd/up-conan-recipes
that referenced
this pull request
May 24, 2024
With eclipse-uprotocol/up-spec#161 and eclipse-uprotocol/up-spec#141, we can now build the up-core-api protobuf library using the standard process for cmake+protobuf. This will result in generated headers and sources correctly referencing the `uprotocol/v1/` include tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the following:
#140