Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to fail API tools on resolution error #3733

Merged
merged 1 commit into from Apr 14, 2024

Conversation

Kummallinen
Copy link
Contributor

Add failOnResolutionError to api-tools configuration, when true it will fail the build if the baseline repository does not correctly resolve. Default to false to maintain existing behaviour, though 'true' is probably the preferred behaviour for many users.

Also adds tests to tycho-its for this

Fixes #3570

@Kummallinen
Copy link
Contributor Author

Windows test failure seems unrelated to my change, looks like an unreliable test:
TestPGPSigning.testSigningBinaries:251 Unexpected unsigned IUs. ==> expected: <[org.eclipse.equinox.common, org.eclipse.equinox.common.source, org.eclipse.osgi, org.eclipse.osgi.source]> but was: <[org.eclipse.equinox.common, org.eclipse.osgi, org.eclipse.osgi.source]>

Copy link

github-actions bot commented Apr 8, 2024

Test Results

  594 files    594 suites   4h 33m 5s ⏱️
  418 tests   410 ✅  7 💤 1 ❌
1 254 runs  1 231 ✅ 22 💤 1 ❌

For more details on these failures, see this check.

Results for commit 7cc3434.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Apr 14, 2024
@laeubi laeubi merged commit dde1dec into eclipse-tycho:main Apr 14, 2024
10 of 12 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@laeubi
Copy link
Member

laeubi commented Apr 14, 2024

@Kummallinen thanks for providing this new option and testcases.

@Kummallinen
Copy link
Contributor Author

@laeubi thank you for the review, merge & backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Tools Plugin should fail the build if the baseline resolution fails
3 participants