Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create extension packages including subsets of built-ins #58

Open
alvsan09 opened this issue Mar 22, 2021 · 7 comments
Open

Create extension packages including subsets of built-ins #58

alvsan09 opened this issue Mar 22, 2021 · 7 comments

Comments

@alvsan09
Copy link
Contributor

The issue is a follow up discussion from 1)
So in addition to create an extension pack listing all existing built-ins, smaller groups of built-in extensions packs are also created.

This issue will be used to track the discussion and decisions for the creation of the initial subset built-in extension packs and the associated extensions.

This task will also follow up the actual implementation for it, including the generalization of the initial implementation as per 1)

  1. List all vscode built-ins #40
@alvsan09
Copy link
Contributor Author

alvsan09 commented Mar 22, 2021

Here goes a generated package.json,
We can use this as a reference to discuss the contents of subset extension packs:

package.txt

@marcdumais-work, @vince-fugnitto , @koegel, Comments are very welcome !

@koegel
Copy link

koegel commented Mar 23, 2021

@alvsan09 Cool, thanks!
@jfaltermeier Can you please compare this with what we require for Theia Blueprint and provide feedback, thanks!

@jfaltermeier
Copy link

The blueprint theia-plugins can be found here: https://github.com/eclipse-theia/theia-blueprint/blob/master/electron-app/package.json#L112
As far as I could see all of the plugins that ship with vscode and are contained in blueprint are also in package.txt

@marcdumais-work
Copy link
Contributor

Note: Vince is working on a mechanism to make sure we install vscode-builtins of a proper version, for the current Theia app, rather than the current default behaviour of chosing latest. This stems from the fact that extensions, referenced from a pack, are not versioned. So it's left to Theia's plugin system I think to do what needs to be done, when resolving/installing extensions from a pack at runtime.

@marcdumais-work
Copy link
Contributor

cc: @vince-fugnitto

@alvsan09
Copy link
Contributor Author

Yes, the related issue mentioned above by Marc is:
eclipse-theia/theia#9224

@marcdumais-work
Copy link
Contributor

I added the issue to the "next" milestone. @vince-fugnitto , please change as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants