Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in's in solid version are being unintentionally published as preview #105

Open
alvsan09 opened this issue Dec 14, 2022 · 2 comments
Open
Labels
bug Something isn't working ci issues related to ci and workflows

Comments

@alvsan09
Copy link
Contributor

When publishing buil-in extensions having a version that includes the 'next' word on it,
they are supposed to be marked as 'preview' which allow consumers to easily identify them before consuming them

however as it can be seen in the picture; Extensions with solid revisions have been already published with the 'preview' flag set to 'true'

There are two sides of this issue:

  1. Correct the logic, so 'next' versions are the only ones marked as 'preview'
  2. Investigate how to correct this in the data base.

Screenshot from 2022-12-14 12-51-53.

@alvsan09 alvsan09 added bug Something isn't working ci issues related to ci and workflows labels Dec 14, 2022
@eclipse-theia eclipse-theia deleted a comment from CiciDongxue Dec 14, 2022
@marcdumais-work
Copy link
Contributor

marcdumais-work commented Dec 14, 2022

Alvaro, as discussed, we currently include the package.json preview flag only for preview (next) extensions:

"preview": true

We can try including it in the future, but set to false for solid revisions and see if it helps.

For what's already published, it seems openvsx would need to revisit their interpretation of what it means when the flag is not present.

Examples of the current situation:

No preview flag is set in package.json, for solid versions. e.g.:
https://open-vsx.org/api/vscode/bat/1.62.3/file/vscode.bat-1.62.3.vsix

The preview flag is set (to true) for next versions:
https://open-vsx.org/api/vscode/bat/1.63.0-next.66b1668b667/file/vscode.bat-1.63.0-next.66b1668b667.vsix

@amvanbaren
Copy link

Hi @marcdumais-work, I think you want to use the --pre-release[1] flag for next versions. It used to be that preview[2] had the functionality of pre-release, but now these flags work the same as on the MS marketplace.

In short, preview is an indicator to a user that the extension (all versions) is not yet feature complete and may contain bugs. While pre-release lets a user regularly get the latest extension version before the official extension release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci issues related to ci and workflows
Projects
None yet
Development

No branches or pull requests

3 participants