Add Neo 2 Layout data #8753
Closed
Add Neo 2 Layout data #8753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for gitpod-io/gitpod#1363 where I have executed the generate-layout script on an Ubuntu 20.10. (Windows 10 does not support Neo 2 layouts afaik)
|
Looks like the ECA check is included in your CI so I'll make sure to sign that. |
|
I have now signed the ECA but I don't know how to retrigger the check. |
|
@kreibaum Hi, in order to pass the ECA check, you will need to sign off your work in your git commit message (sign your work) |
| @@ -0,0 +1 @@ | |||
| {"info":{"model":"pc105","layout":"de,de,us","variant":"neo,,","options":"","rules":"evdev"},"mapping":{"KeyA":{"value":"u","withShift":"U","withAltGr":"\\"},"KeyB":{"value":"z","withShift":"Z","withAltGr":"`","withShiftAltGr":"ζ"},"KeyC":{"value":"ä","withShift":"Ä","withAltGr":"|","withShiftAltGr":"η"},"KeyD":{"value":"a","withShift":"A","withAltGr":"{","withShiftAltGr":"α"},"KeyE":{"value":"l","withShift":"L","withAltGr":"[","withShiftAltGr":"λ"},"KeyF":{"value":"e","withShift":"E","withAltGr":"}","withShiftAltGr":"ε"},"KeyG":{"value":"o","withShift":"O","withAltGr":"*","withShiftAltGr":"ο"},"KeyH":{"value":"s","withShift":"S","withAltGr":"?","withShiftAltGr":"σ"},"KeyI":{"value":"g","withShift":"G","withAltGr":">","withShiftAltGr":"γ"},"KeyJ":{"value":"n","withShift":"N","withAltGr":"(","withShiftAltGr":"ν"},"KeyK":{"value":"r","withShift":"R","withAltGr":")","withShiftAltGr":"ρ"},"KeyL":{"value":"t","withShift":"T","withAltGr":"-","withShiftAltGr":"τ"},"KeyM":{"value":"m","withShift":"M","withAltGr":"%","withShiftAltGr":"μ"},"KeyN":{"value":"b","withShift":"B","withAltGr":"+","withShiftAltGr":"β"},"KeyO":{"value":"f","withShift":"F","withAltGr":"=","withShiftAltGr":"φ"},"KeyP":{"value":"q","withShift":"Q","withAltGr":"&","withShiftAltGr":"ϕ"},"KeyQ":{"value":"x","withShift":"X","withAltGr":"…","withShiftAltGr":"ξ"},"KeyR":{"value":"c","withShift":"C","withAltGr":"]","withShiftAltGr":"χ"},"KeyS":{"value":"i","withShift":"I","withAltGr":"/","withShiftAltGr":"ι"},"KeyT":{"value":"w","withShift":"W","withAltGr":"^","withShiftAltGr":"ω"},"KeyU":{"value":"h","withShift":"H","withAltGr":"<","withShiftAltGr":"ψ"},"KeyV":{"value":"p","withShift":"P","withAltGr":"~","withShiftAltGr":"π"},"KeyW":{"value":"v","withShift":"V","withAltGr":"_"},"KeyX":{"value":"ö","withShift":"Ö","withAltGr":"$","withShiftAltGr":"ϵ"},"KeyY":{"value":"k","withShift":"K","withAltGr":"!","withShiftAltGr":"κ"},"KeyZ":{"value":"ü","withShift":"Ü","withAltGr":"#"},"Digit1":{"value":"1","withShift":"°","withAltGr":"¹","withShiftAltGr":"₁"},"Digit2":{"value":"2","withShift":"§","withAltGr":"²","withShiftAltGr":"₂"},"Digit3":{"value":"3","withShift":"ℓ","withAltGr":"³","withShiftAltGr":"₃"},"Digit4":{"value":"4","withShift":"»","withAltGr":"›","withShiftAltGr":"♀"},"Digit5":{"value":"5","withShift":"«","withAltGr":"‹","withShiftAltGr":"♂"},"Digit6":{"value":"6","withShift":"$","withAltGr":"¢","withShiftAltGr":"⚥"},"Digit7":{"value":"7","withShift":"€","withAltGr":"¥","withShiftAltGr":"ϰ"},"Digit8":{"value":"8","withShift":"„","withAltGr":"‚","withShiftAltGr":"⟨"},"Digit9":{"value":"9","withShift":"“","withAltGr":"‘","withShiftAltGr":"⟩"},"Digit0":{"value":"0","withShift":"”","withAltGr":"’","withShiftAltGr":"₀"},"Minus":{"value":"-","withShift":"—","withShiftAltGr":"‑"},"Equal":{"value":"̀","withShift":"̧","withAltGr":"̊","withShiftAltGr":"̔"},"BracketLeft":{"value":"ß","withShift":"ẞ","withAltGr":"ſ","withShiftAltGr":"ς"},"BracketRight":{"value":"́","withShift":"̃","withAltGr":"̸","withShiftAltGr":"̓"},"Semicolon":{"value":"d","withShift":"D","withAltGr":":","withShiftAltGr":"δ"},"Quote":{"value":"y","withShift":"Y","withAltGr":"@","withShiftAltGr":"υ"},"Backquote":{"value":"̂","withShift":"̌","withAltGr":"↻","withShiftAltGr":"˞"},"Comma":{"value":",","withShift":"–","withAltGr":"\"","withShiftAltGr":"ϱ"},"Period":{"value":".","withShift":"•","withAltGr":"'","withShiftAltGr":"ϑ"},"Slash":{"value":"j","withShift":"J","withAltGr":";","withShiftAltGr":"θ"}}} | |||
There was a problem hiding this comment.
minor: please include a newline in addition to fixing the sign-off.
vince-fugnitto
added
enhancement
|
@kreibaum do you still plan on updating the pull-request? |
|
Yes I do. Sorry that I didn't get around to that yet. Will still take a while to find time. If you prefer, you can close this PR and I'll create a new one later. |
There's no rush, we look forward to your contribution :) |
|
With the Code IDE in Gitpod not having this problem and it becoming the default soon, I'll instead switch over to that and close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for gitpod-io/gitpod#1363 where I have executed the generate-layout script on an Ubuntu 20.10. (Windows 10 does not support Neo 2 layouts afaik)
Since I just followed instructions and uploaded a generated file, I don't think the Eclipse Contributor Agreement (ECA) is required. If you think otherwise I can of course do that step.
What it does
Adds the result of
yarn --cwd packages/core generate-layout --output src/common/keyboard/layouts/de-Neo_2-pc.jsonHow to test
Choose Neo 2 Keyboard in (linux) keyboard settings. Then check if shortcuts work. (e.g. Copy + Paste) This is of course hard to do if you don't have the layout memorized :-/
Review checklist
No. I have just uploaded the generated file.
Reminder for reviewers