Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default translation of Close Editor command #13412

Merged
merged 1 commit into from Mar 21, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 22, 2024

What it does

Closes #13333

Adds a new entry to our preferred keys to correctly localize the value.

How to test

  1. Configure Theia to use the simplified chinese local (zh-cn).
  2. Assert that the command Close Editor (see picture in the linked issue) is localized.

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Feb 22, 2024
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JonasHelming
Copy link
Contributor

@jonah-iden As Mark is on vacation, do you want to merge this?

@jonah-iden
Copy link
Contributor

jonah-iden commented Mar 21, 2024

@JonasHelming sure i can do that

@jonah-iden jonah-iden merged commit c293554 into master Mar 21, 2024
14 checks passed
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

"Close Editor" in the File menu did not get the correct translation value
4 participants