Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage does not show a launcher Icon anymore + Remove all usages of app-builder-lib@23.6.0 + yarn upgrade #343

Merged
merged 3 commits into from May 16, 2024

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Mar 27, 2024

What it does

Removes remaining usage of app-builder-lib@23.6.0 that was not updated by the dependabot PR

Upgrades all dependencies

Fixes #361 AppImage does not show a launcher Icon anymore

Contributed on behalf of STMicroelectronics

How to test

Build application on Linux and check that icon is showing.

Review checklist

Reminder for reviewers

Contributed on behalf of STMicroelectronics
Contributed on behalf of STMicroelectronics
@jfaltermeier jfaltermeier changed the title WIP: Remove all usages of app-builder-lib@23.6.0 WIP: Prepare 1.50: Remove all usages of app-builder-lib@23.6.0, yarn upgrade May 8, 2024
@jfaltermeier jfaltermeier changed the title WIP: Prepare 1.50: Remove all usages of app-builder-lib@23.6.0, yarn upgrade WIP: Prepare 1.50: Remove all usages of app-builder-lib@23.6.0 + yarn upgrade May 8, 2024
* splash screen windows may exist already, so we have to update existing
windows as well

Contributed on behalf of STMicroelectronics
@jfaltermeier jfaltermeier changed the title WIP: Prepare 1.50: Remove all usages of app-builder-lib@23.6.0 + yarn upgrade AppImage does not show a launcher Icon anymore + Remove all usages of app-builder-lib@23.6.0 + yarn upgrade May 15, 2024
@jfaltermeier jfaltermeier marked this pull request as ready for review May 16, 2024 06:58
@jfaltermeier
Copy link
Contributor Author

Eclipse CI working again after https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4636

@jfaltermeier jfaltermeier merged commit bfa92d0 into master May 16, 2024
6 checks passed
@jfaltermeier jfaltermeier deleted the jf/installer-update branch May 16, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppImage does not show a launcher Icon anymore
2 participants