Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3391] Accept gradient for node background #3394

Merged
merged 1 commit into from May 7, 2024

Conversation

frouene
Copy link
Contributor

@frouene frouene commented Apr 16, 2024

Bug: #3391

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

Copy link
Member

@sbegaudeau sbegaudeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this change at all but we have to be consistent. Could you change the GraphQL schema and the background code to match this new behavior please? You may also need a migration participant in sirius-web-application to match the new name.

@frouene frouene linked an issue Apr 19, 2024 that may be closed by this pull request
@frouene frouene force-pushed the fro/fix/gradient-background branch from 66deadc to ede8112 Compare April 19, 2024 15:11
@frouene frouene requested a review from pcdavid as a code owner April 19, 2024 15:11
@frouene
Copy link
Contributor Author

frouene commented Apr 19, 2024

Wait for migration participant to be merged to add a new one

@frouene frouene force-pushed the fro/fix/gradient-background branch 6 times, most recently from 67952c5 to bc4a863 Compare April 25, 2024 16:24
@frouene
Copy link
Contributor Author

frouene commented Apr 26, 2024

A new participant migration has been add

@frouene frouene force-pushed the fro/fix/gradient-background branch 4 times, most recently from a603957 to c4d8821 Compare April 29, 2024 14:05
CHANGELOG.adoc Outdated Show resolved Hide resolved
@frouene frouene force-pushed the fro/fix/gradient-background branch 2 times, most recently from 41b0c47 to 029350b Compare May 6, 2024 06:53
@sbegaudeau sbegaudeau force-pushed the fro/fix/gradient-background branch from 029350b to 8852f39 Compare May 6, 2024 09:27
@frouene frouene force-pushed the fro/fix/gradient-background branch 3 times, most recently from e81958c to a417115 Compare May 7, 2024 08:54
Bug: #3391
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene force-pushed the fro/fix/gradient-background branch from a417115 to 418c572 Compare May 7, 2024 12:03
@sbegaudeau sbegaudeau merged commit c1791c9 into master May 7, 2024
4 checks passed
@sbegaudeau sbegaudeau deleted the fro/fix/gradient-background branch May 7, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradient are not available for node background
3 participants