New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3391] Accept gradient for node background #3394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this change at all but we have to be consistent. Could you change the GraphQL schema and the background code to match this new behavior please? You may also need a migration participant in sirius-web-application to match the new name.
66deadc
to
ede8112
Compare
Wait for migration participant to be merged to add a new one |
67952c5
to
bc4a863
Compare
A new participant migration has been add |
a603957
to
c4d8821
Compare
41b0c47
to
029350b
Compare
029350b
to
8852f39
Compare
...nts-view-emf/src/main/java/org/eclipse/sirius/components/view/emf/diagram/StylesFactory.java
Outdated
Show resolved
Hide resolved
...f/src/main/java/org/eclipse/sirius/components/view/emf/diagram/FormDescriptionValidator.java
Outdated
Show resolved
Hide resolved
packages/view/backend/sirius-components-view-diagram/src/main/resources/model/diagram.ecore
Show resolved
Hide resolved
packages/sirius-web/backend/sirius-web/src/test/resources/scripts/migration.sql
Show resolved
Hide resolved
packages/sirius-web/backend/sirius-web/src/test/resources/scripts/migration.sql
Show resolved
Hide resolved
...s-web/src/test/java/org/eclipse/sirius/web/services/migration/MigrationParticipantTests.java
Show resolved
Hide resolved
...a/org/eclipse/sirius/web/sample/papaya/view/classdiagram/CDClassNodeDescriptionProvider.java
Outdated
Show resolved
Hide resolved
...ion/editingcontext/migration/participants/NodeStyleDescriptionColorMigrationParticipant.java
Outdated
Show resolved
Hide resolved
e81958c
to
a417115
Compare
Bug: #3391 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
a417115
to
418c572
Compare
Bug: #3391
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request