Add ScoutTemplateContextType #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschinkel
changed the title
Restrict liveTemplates for DoNodes to DoEntities.
fschinkel
force-pushed
the
features/fschinkel/13.0/ScoutTemplateContextType
branch
from
c7f469e
to
696d06d
Compare
mvilliger
reviewed
May 1, 2023
| val module = element.containingModule() ?: return false | ||
| val clazz = PsiTreeUtil.getParentOfType(element, PsiClass::class.java) ?: return false | ||
| return IdeaEnvironment.callInIdeaEnvironmentSync(module.project, IdeaProgress.empty()) { env, _ -> | ||
| val type = clazz.toScoutType(env) ?: return@callInIdeaEnvironmentSync false |
There was a problem hiding this comment.
Is the transformation from PsiClass to IType really necessary? Because this loads the classpath and is therefore quite expensive just to perform a check of the super-hierarchy. Maybe use InheritanceUtil on clazz instead?
Then the IdeaEnvironment must not be created explicitly and the code becomes much simpler?
fschinkel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict liveTemplates for DoNodes to DoEntities.