Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4973 improve performance og inner merge join #4975

Merged
merged 13 commits into from May 16, 2024

Conversation

hmottestad
Copy link
Contributor

@hmottestad hmottestad commented May 10, 2024

GitHub issue resolved: #4973

Briefly describe the changes proposed in this PR:


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@kenwenzel
Copy link
Contributor

I am not sure if something like this could be also helpful in some situations:
https://github.com/linkedfactory/linkedfactory-pod/blob/main/bundles/io.github.linkedfactory.core/src/main/java/io/github/linkedfactory/core/rdf4j/common/query/CompositeBindingSet.java

The binding set is helpful if only few additional bindings are generated via a join. I use this for evaluating joins over time series data.

@hmottestad
Copy link
Contributor Author

Ahh. So you can keep multiple references to a single binding set and for each of them add another value.

I once made a StatementBindingSet that wrapped a statement and transparently mapped the variable names to the correct component of the statement. That in combination with your suggestion could really make for a much more lightweight binding set.

@hmottestad hmottestad force-pushed the GH-4973-improve-performance-og-inner-merge-join branch from 9be44af to 6b61583 Compare May 15, 2024 06:50
@hmottestad hmottestad force-pushed the GH-4973-improve-performance-og-inner-merge-join branch from 6b61583 to 14b7a60 Compare May 15, 2024 06:53
@hmottestad
Copy link
Contributor Author

Squash and merge!

@hmottestad hmottestad marked this pull request as ready for review May 16, 2024 08:23
@hmottestad hmottestad merged commit a7a3171 into develop May 16, 2024
9 checks passed
@hmottestad hmottestad deleted the GH-4973-improve-performance-og-inner-merge-join branch May 16, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants