Gh 4899 allow for storage specialization in path iteration #4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different constructions. Introduce optimise-able data-structures in the collection factory for ValuePair used in the PathIteration without exposing the type by wrapping making it extend BindingSet.
JervenBolleman
added
🐞 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #4899
Briefly describe the changes proposed in this PR:
The PathIterartion has a data structure for a pair of values. I made this extend
BindingSetso that we can use the capability for implementing specialized collections also for this value pairs.While doing so I noticed a bug due to a path name not being the same in places. Avoided this in the future by using methods to generate the same string for a variable name by reducing code duplication.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)