Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4962: invalidation support for FedX source selection cache + factory #4966

Merged
merged 1 commit into from May 15, 2024

Conversation

aschwarte10
Copy link
Contributor

GitHub issue resolved: #4962

Briefly describe the changes proposed in this PR:

  • provide a means for externally invalidating the FedX source selection cache (e.g. upon writes)
  • provide a means for configuring a custom source selection cache implementation

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Copy link
Contributor

@JervenBolleman JervenBolleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge.

@@ -0,0 +1,26 @@
/*******************************************************************************
* Copyright (c) 2020 Eclipse RDF4J contributors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, good catch!

* provide a means for externally invalidating the FedX source selection
cache (e.g. upon writes)
* provide a means for configuring a custom source selection cache
implementation
@aschwarte10 aschwarte10 force-pushed the GH-4962-fedx-cache-invalidation branch from 005ae28 to 2f15974 Compare May 13, 2024 19:08
@aschwarte10 aschwarte10 merged commit ceb8156 into develop May 15, 2024
8 of 9 checks passed
@aschwarte10 aschwarte10 deleted the GH-4962-fedx-cache-invalidation branch May 15, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants