New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-4954 LMDB: Fix GC and record counting for deletions #4955
GH-4954 LMDB: Fix GC and record counting for deletions #4955
Conversation
b836747
to
80e8c60
Compare
@kenwenzel You know you have committer rights now so you don't have to use your fork anymore. |
Thank you for the.hint. Do you prefer the creation of branches in this repo rather than using a/my fork? |
The failing integration tests: It's a test that is marked as disabled, but has somehow started to run again. Not sure how that happened. |
Ensures that GC is also working if triple store needs to grow and that the correct count is returned for statement removals.
80e8c60
to
b784f07
Compare
Would be nice if you used the RDF4J repo. Nice thing is that it allows others to work on your branch, though that's probably not going to happen very often. |
@hmottestad Should I merge this on my own? |
I prefer if you request a code review. It doesn't have to be me doing the code review, can also be someone else who is active on the project, at the moment it's mostly Jerven who is active. You can request a review from either one of us, and if you get an "approval" then feel free to merge it. If you don't get a response to your review request ping me and if you still don't hear anything after a few more days then feel free to do a "self review" and merge. Unless you feel that your changes are very big, a fundamental change or you have a funky solution to something that you want feedback on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I understand much of what's going on. LGTM.
Ensures that GC is also working if triple store needs to grow and that the correct count is returned for statement removals.
GitHub issue resolved: #4954
Briefly describe the changes proposed in this PR:
Tests removed values after the triple store's transaction is committed and correctly calls handler in removeStatement methods.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)