Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4544 Openrewrite migration to junit5. #4851

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JervenBolleman
Copy link
Contributor

@JervenBolleman JervenBolleman commented Nov 26, 2023

Junit4 is still used in a few places, one for lucene or guavatestlibs that don't have an junit4 equivalent

GitHub issue resolved: #4544

Briefly describe the changes proposed in this PR:

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run   \ -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE   \
-Drewrite.activeRecipes=org.openrewrite.java.testing.junit5.JUnit4to5Migration

Then reverting any module with compiler issues and throwing away all pom changes.


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

…w places, one for lucene or guavatestlibs that don't have an junit4 equivalent

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
@JervenBolleman JervenBolleman self-assigned this Nov 26, 2023
@JervenBolleman JervenBolleman added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label Nov 26, 2023
@JervenBolleman JervenBolleman added this to the 5.0.0 milestone Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant