Gh 4581 remove jerven design mistakes #4582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JervenBolleman
added
the
🛠️ tech debt
JervenBolleman
force-pushed
the
GH-4581-Remove-Jerven-Design-Mistakes
branch
from
b12ed0f
to
4b30d24
Compare
As well as supplier methods later better done with the collection factory API. Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman
force-pushed
the
GH-4581-Remove-Jerven-Design-Mistakes
branch
from
4b30d24
to
b241e9b
Compare
This allows to always be sure that we can fall back to disk if required. Also allows optimized datastructures to be injected. Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman
force-pushed
the
GH-4581-Remove-Jerven-Design-Mistakes
branch
from
b241e9b
to
f8f7eee
Compare
|
@hmottestad could this still be included in the next 5.x Milestone build? |
Yeah. I haven't started on the build process yet. I saw you requested a review from me, so I'll take a look asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #
Briefly describe the changes proposed in this PR:
Remove LimitedSize evaluation strategy code, as well as a few methods in the EvaluationStrategy API that was replaced by the collection factory API.
Closes #4581