WIP: Migrate JUnit4 test suites to JUnit5 nested tests #4438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
suite-to-junit5-nested
branch
4 times, most recently
from
6eaa402
to
0adf40f
Compare
erikgb
force-pushed
the
suite-to-junit5-nested
branch
from
0adf40f
to
1c0699f
Compare
erikgb
force-pushed
the
suite-to-junit5-nested
branch
from
1c0699f
to
25c7555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been looking at migrating the JUnit4 test suites to JUnit5, and it is definitely not straightforward. If junit-team/junit5#456 was resolved, that could help, but I am not sure if the JUnit5 test suite concept really is what we want.
This PR suggests migrating these test suites to JUnit5 by replacing the suite declaration with JUnit5 nested tests. @abrokenjester @hmottestad WDYT? This can be improved further, but I tried to make minimal changes in the initial migration. I can create a new issue and PR if you think this looks promising. Please let me know.