Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for invalidation of FedX SourceSelectionCache and allow custom implementations #4962

Closed
aschwarte10 opened this issue Apr 22, 2024 · 0 comments
Assignees
Labels
📶 enhancement issue is a new feature or improvement 📦 fedx fedx: optimized federated query support
Milestone

Comments

@aschwarte10
Copy link
Contributor

Problem description

The current implementation of the FedX source selection relies on an in-memory guava cache. Via configuration it is possible already to configure the specification of the guava cache (e.g. to set expiration time)

What is currently missing is the possibility to invalidate the cache upon write operations to one of the federation members.

In addition, the implementation of the cache cannot be adjusted in extensions, as it is created in non-accessible code in org.eclipse.rdf4j.federated.FederationContext.createSourceSelectionCache(). Note that the cache itself is defined in an interface already.

Preferred solution

For the first part of the enhancement, it is desired to add invalidate methods to the org.eclipse.rdf4j.federated.cache.SourceSelectionCache interface

For the second part, it can be an option to define the source selection implementation using FedXConfig, maybe similar to the TaskWrapper.

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

No response

Anything else?

No response

@aschwarte10 aschwarte10 added the 📶 enhancement issue is a new feature or improvement label Apr 22, 2024
@aschwarte10 aschwarte10 self-assigned this Apr 22, 2024
@aschwarte10 aschwarte10 added this to the 5.0.0 milestone Apr 22, 2024
@aschwarte10 aschwarte10 added the 📦 fedx fedx: optimized federated query support label Apr 22, 2024
aschwarte10 added a commit that referenced this issue Apr 29, 2024
* provide a means for externally invalidating the FedX source selection
cache (e.g. upon writes)
* provide a means for configuring a custom source selection cache
implementation
aschwarte10 added a commit that referenced this issue May 13, 2024
* provide a means for externally invalidating the FedX source selection
cache (e.g. upon writes)
* provide a means for configuring a custom source selection cache
implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📶 enhancement issue is a new feature or improvement 📦 fedx fedx: optimized federated query support
Projects
None yet
Development

No branches or pull requests

1 participant