Replace deprecated core.launcher.Main by equinox.launcher.Main

[HannesWell]

Required for eclipse-equinox/equinox#562

[github-actions]

Test Results

   617 files  ±0     617 suites  ±0   43m 41s ⏱️ + 6m 9s
 3 945 tests ±0   3 880 ✅ ±0   23 💤 ±0   40 ❌ ±0  2 🔥 ±0 
12 292 runs  ±0  12 004 ✅ ±0  164 💤 ±0  118 ❌ ±0  6 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit efc1ff8. ± Comparison against base commit 072423e.

[HannesWell]

The test-failures seem to be the same as on the master, but I assume they are caused by eclipse-platform/eclipse.platform.releng.aggregator#1919 (comment), aren't they?
I'll await tonight's I-build and hope the build is then green again.

[HeikoKlare]

The test-failures seem to be the same as on the master, but I assume they are caused by eclipse-platform/eclipse.platform.releng.aggregator#1919 (comment), aren't they?
I'll await tonight's I-build and hope the build is then green again.

Probably, yes. The same failures occur in other PRs, such as #852. I've retriggered the GH actions for #852 this morning, when yesterday's I-Build had been deployed, but the same failures still occur.

[akurtakov]

In https://github.com/eclipse-platform/eclipse.platform/actions/runs/8426539577/job/23092286324?pr=1266 I can see it's some test failure in ant.tests.ui but can't figure more from the log. Can someone help finding the details?

[akurtakov]

As Jenkins succeeds it's fine to merge.

[HannesWell]

The test-failures seem to be the same as on the master, but I assume they are caused by eclipse-platform/eclipse.platform.releng.aggregator#1919 (comment), aren't they?
I'll await tonight's I-build and hope the build is then green again.

Probably, yes. The same failures occur in other PRs, such as #852. I've retriggered the GH actions for #852 this morning, when yesterday's I-Build had been deployed, but the same failures still occur.

Thanks Heiko.
It might still happen since I-builds are unstable since https://download.eclipse.org/eclipse/downloads/drops4/I20240324-1800/.
But I don't have time to investigate before this evening, although just fixing it would be simple since just one bundle is affected in the latest build.

As Jenkins succeeds it's fine to merge.

Me too and since the deprecated class just wraps the replacement in the same bundle I think it is relatively save. When I used it locally in my IDE it worked.

[HeikoKlare]

In https://github.com/eclipse-platform/eclipse.platform/actions/runs/8426539577/job/23092286324?pr=1266 I can see it's some test failure in ant.tests.ui but can't figure more from the log. Can someone help finding the details?

I did not have time to investigate yet, but I could imagine that this is somehow related to using a Java 21 JVM. I also face and currently investigate issues in another PR, in which a test is working fine when run with a Java 17 JVM but does not succeed with a Java 21 one: eclipse-platform/eclipse.platform.ui#1775

[HeikoKlare]

I just verified: Running the Ant UI tests with a Java 21 JVM locally produces the same test failures as the GH actions builds here.

[merks]

I wonder if -Djava.security.manager=allow makes a different to the test behavior?

[akurtakov]

https://ci.eclipse.org/platform/job/eclipse.platform/job/master/768/ is finally a good build with even comparator issues fixed.

[HeikoKlare]

I wonder if -Djava.security.manager=allow makes a different to the test behavior?

Yes, that makes the Ant UI tests run properly.