Adding Javadoc #1885
Merged
Adding Javadoc #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 812 files ±0 1 812 suites ±0 1h 29m 35s ⏱️ - 5m 47s For more details on these failures, see this check. Results for commit da4a368. ± Comparison against base commit f981728. ♻️ This comment has been updated with latest results. |
|
To me, these failures seem to be infrastructure related- not related to the PR changes. Are there known CI issues? |
|
Looks like a bug in PDE API tools... |
|
Given the current freeze period, I will merge these changes once the development cycle reopens, as the test failures are unrelated to the changes. |
|
As mentioned in the "RC1 reminder" mail, "Ongoing changes to documentation, tests or examples do not require approval.” |
mickaelistria
merged commit 30bc1dc
into
eclipse-platform:master
13 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Javadoc for the cleanUp() in CocoaDarkThemeProcessor.