Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle spaces in installation paths in WindowsDefenderConfigurator #1772

Merged
merged 1 commit into from Mar 23, 2024
Merged

Handle spaces in installation paths in WindowsDefenderConfigurator #1772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion ....eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WindowsDefenderConfigurator.java
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@

import java.io.BufferedReader;
import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Path;
Expand All @@ -37,6 +38,7 @@
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.SubMonitor;
import org.eclipse.core.runtime.URIUtil;
import org.eclipse.core.runtime.jobs.Job;
import org.eclipse.core.runtime.preferences.ConfigurationScope;
import org.eclipse.core.runtime.preferences.IEclipsePreferences;
Expand Down Expand Up @@ -270,7 +272,8 @@ private static Optional<Path> getInstallationLocation() {
// https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fruntime-options.html&anchor=locations
try {
Location installLocation = Platform.getConfigurationLocation();
return Optional.of(Path.of(installLocation.getURL().toURI())); // assume location has a file-URL
URI location = URIUtil.toURI(installLocation.getURL());
return Optional.of(Path.of(location)); // assume location has a file-URL
} catch (URISyntaxException e) { // ignore
}
return Optional.empty();
Expand Down