Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of actually internal SWT TypedListener #1766

Merged
merged 1 commit into from Mar 20, 2024

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Mar 19, 2024

Use the new API introduced in SWT via eclipse-platform/eclipse.platform.swt#1112

This also fixes the new API-tools warnings about illegal instantiations of TypedListener.

@HannesWell HannesWell force-pushed the replace-TypedListener branch 3 times, most recently from 9f9682a to 280a841 Compare March 19, 2024 22:49
@HannesWell
Copy link
Member Author

Without re-exported required bundles this would be a much simpler change. :/

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Test Results

   918 files  ±0     918 suites  ±0   1h 6m 57s ⏱️ + 18m 14s
 7 507 tests ±0   7 355 ✅ +1  151 💤 ±0  1 ❌  - 1 
23 670 runs  ±0  23 164 ✅ +1  505 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit 13e0312. ± Comparison against base commit 1122c63.

♻️ This comment has been updated with latest results.

@akurtakov akurtakov merged commit 0de600a into eclipse-platform:master Mar 20, 2024
14 of 16 checks passed
@HannesWell HannesWell deleted the replace-TypedListener branch March 20, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants