Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentangle suppressed fields #1457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented Jan 2, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Test Results

   894 files   -     6     894 suites   - 6   24m 50s ⏱️ - 23m 8s
 5 767 tests  - 1 703   5 735 ✅  - 1 582   32 💤  - 121  0 ❌ ±0 
18 450 runs   - 5 109  18 308 ✅  - 4 740  142 💤  - 369  0 ❌ ±0 

Results for commit 4a72735. ± Comparison against base commit 6161ab1.

This pull request removes 1703 tests.
org.eclipse.ui.internal.ide.ChooseWorkspaceDialogTests ‑ testFilterDuplicatedPaths
org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTest ‑ fileSeparatorOpensProposalPopup
org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTest ‑ opensProposalPopupWithSubfoldersAsProposals
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAll
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksAndEndTerminator
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksForGaps
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksForOneGap
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testCapitalizedText
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testCaseInsensitivity
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testEndTerminator
…

♻️ This comment has been updated with latest results.

@elsazac
Copy link
Member Author

elsazac commented Jan 5, 2024

upon reviewing my own changes on a second thought I now wonder whether these fields are really named as such to override their parent counterparts as supposed to named in error.
If it is the former I could revert the changes and suppress the warnings ( @SuppressWarnings("hiding") ). If it is the latter case the changes are good as is.

Is there any way I can find out?

@mickaelistria mickaelistria force-pushed the refactor_disentangle_suppressedfields branch from 021d3af to 4a72735 Compare January 8, 2024 09:09
@mickaelistria
Copy link
Contributor

@elsazac
Copy link
Member Author

elsazac commented Jan 8, 2024

https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-1457/2/console mentions some new test failures.

I don't see any new failures in the link you provided. Can you please double check?

@mickaelistria
Copy link
Contributor

I've not looked up for details but

09:31:10.444 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.5-SNAPSHOT:test (default-test) on project org.eclipse.ui.tests: There are test failures.
09:31:10.444 [ERROR] 
09:31:10.444 [ERROR] Please refer to /home/jenkins/agent/workspace/eclipse.platform.ui_PR-1457/tests/org.eclipse.ui.tests/target/surefire-reports for the individual test results.
09:31:10.444 [ERROR] -> [Help 1]
09:31:10.444 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.5-SNAPSHOT:test (default-test) on project org.eclipse.ui.tests.navigator: There are test failures.
09:31:10.444 [ERROR] 
09:31:10.444 [ERROR] Please refer to /home/jenkins/agent/workspace/eclipse.platform.ui_PR-1457/tests/org.eclipse.ui.tests.navigator/target/surefire-reports for the individual test results.

doesn't appear on other builds as far as I know.

@elsazac
Copy link
Member Author

elsazac commented Jan 8, 2024

I've not looked up for details but

09:31:10.444 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.5-SNAPSHOT:test (default-test) on project org.eclipse.ui.tests: There are test failures.
09:31:10.444 [ERROR] 
09:31:10.444 [ERROR] Please refer to /home/jenkins/agent/workspace/eclipse.platform.ui_PR-1457/tests/org.eclipse.ui.tests/target/surefire-reports for the individual test results.
09:31:10.444 [ERROR] -> [Help 1]
09:31:10.444 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.5-SNAPSHOT:test (default-test) on project org.eclipse.ui.tests.navigator: There are test failures.
09:31:10.444 [ERROR] 
09:31:10.444 [ERROR] Please refer to /home/jenkins/agent/workspace/eclipse.platform.ui_PR-1457/tests/org.eclipse.ui.tests.navigator/target/surefire-reports for the individual test results.

doesn't appear on other builds as far as I know.

I am still learning to interpret the CI log but this is what I get

#grep "Failures" ci.html | awk -F' ' '{print $1 $2 $3 $4 $5 $6 $7}' Testsrun:399,Failures:0,Errors:0, Testsrun:399,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:13,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:14,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:15,Failures:0,Errors:0, Testsrun:42,Failures:0,Errors:0, Testsrun:986,Failures:0,Errors:0, Testsrun:986,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:7,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:52,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:7,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:11,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:25,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:18,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:12,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:199,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:182,Failures:0,Errors:0, Testsrun:176,Failures:0,Errors:0, Testsrun:360,Failures:0,Errors:0, Testsrun:16,Failures:0,Errors:0, Testsrun:16,Failures:0,Errors:0, Testsrun:32,Failures:0,Errors:0, Testsrun:1227,Failures:0,Errors:0, Testsrun:1227,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:14,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:16,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:15,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:14,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:11,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:27,Failures:0,Errors:0, Testsrun:13,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:16,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:14,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:19,Failures:0,Errors:0, Testsrun:7,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:12,Failures:0,Errors:0, Testsrun:15,Failures:0,Errors:0, Testsrun:12,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:16,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:45,Failures:0,Errors:0, Testsrun:22,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:21,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:25,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:7,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:7,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:7,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:14,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:18,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:49,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:7,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:19,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:20,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:18,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:50,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:8,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:1067,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:10,Failures:0,Errors:0, Testsrun:577,Failures:0,Errors:0, Testsrun:577,Failures:0,Errors:0, Testsrun:291,Failures:0,Errors:0, Testsrun:291,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:0,Failures:0,Errors:0, Testsrun:22,Failures:0,Errors:0, Testsrun:32,Failures:0,Errors:0, Testsrun:0,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:0,Failures:0,Errors:0, Testsrun:12,Failures:0,Errors:0, Testsrun:13,Failures:0,Errors:0, Testsrun:0,Failures:0,Errors:0, Testsrun:90,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:0,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:46,Failures:0,Errors:0, Testsrun:46,Failures:0,Errors:0, Testsrun:23,Failures:0,Errors:0, Testsrun:12,Failures:0,Errors:0, Testsrun:13,Failures:0,Errors:0, Testsrun:29,Failures:0,Errors:0, Testsrun:12,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:11,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:110,Failures:0,Errors:0, Testsrun:5,Failures:0,Errors:0, Testsrun:224,Failures:0,Errors:0, Testsrun:1,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:13,Failures:0,Errors:0, Testsrun:73,Failures:0,Errors:0, Testsrun:73,Failures:0,Errors:0, Testsrun:93,Failures:0,Errors:0, Testsrun:93,Failures:0,Errors:0, Testsrun:44,Failures:0,Errors:0, Testsrun:44,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:16,Failures:0,Errors:0, Testsrun:7,Failures:0,Errors:0, Testsrun:26,Failures:0,Errors:0, Testsrun:15,Failures:0,Errors:0, Testsrun:15,Failures:0,Errors:0, Testsrun:131,Failures:0,Errors:0, Testsrun:131,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:30,Failures:0,Errors:0, Testsrun:30,Failures:0,Errors:0, Testsrun:4,Failures:0,Errors:0, Testsrun:6,Failures:0,Errors:0, Testsrun:34,Failures:0,Errors:0, Testsrun:9,Failures:0,Errors:0, Testsrun:12,Failures:0,Errors:0, Testsrun:3,Failures:0,Errors:0, Testsrun:68,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:2,Failures:0,Errors:0, Testsrun:11,Failures:0,Errors:0, Testsrun:13,Failures:0,Errors:0, Testsrun:24,Failures:0,Errors:0,

@mickaelistria
Copy link
Contributor

The message is misleading, if you scroll up in the log to where "org.eclipse.ui.tests" is built and look at tycho-surefire-plugin execution from it, you'll see it doesn't log any test progress. This is usually a symptom that something fails even before execution of tests.
In such case, I would recommend you try a local Maven build of the repository to see if you can reproduce the issue locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants