Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ZWSP (zero with space) as code mining #1437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcushoepfner
Copy link
Contributor

Issue: #1002

For more information refer to https://www.compart.com/en/unicode/U+200B To get a ZWSP refer to https://zerowidthspace.me/

@@ -0,0 +1,24 @@
package org.eclipse.ui.internal.texteditor.codemining;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing co[yright header

Copy link
Contributor

Test Results

     900 files  +       1       900 suites  +1   46m 55s ⏱️ + 7m 56s
  7 470 tests ±       0    7 316 ✔️ +       2  153 💤 ±    0  1  - 1 
23 559 runs  +1 577  23 047 ✔️ +1 458  511 💤 +121  1  - 1 

For more details on these failures, see this check.

Results for commit e7d0acd. ± Comparison against base commit 44efc1d.

@BeckerWdf
Copy link
Contributor

BeckerWdf commented Dec 20, 2023

I did a quick manual test on macOS. I found the following issues:

  1. code mining is not displayed emidiately. I have to close and reopen the editor for the code minings to be shown
  2. Two ZWSP next to each other are drawn one the (almost?) same location. See line 4 in:
image
  1. When select the "a" and the "ZWSP" in line 2 from the above screenshot to with the keyboard I have to press the right-cursor two times until the caret is behind the "ZWSP".


public class ZeroWidthSpaceLineContentCodeMiningProvider extends AbstractCodeMiningProvider {

private static final char ZWSP_SIGN = '\u200b';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add

\u200c  zero width non-joiner
\u200d  zero width joiner
\ufeff  zero width no break space

See: https://plugins.jetbrains.com/plugin/7448-zero-width-characters-locator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants