Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change isExpandableNode API signature to accept Item as parameter. #1151

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raghucssit
Copy link
Contributor

We need to let client know that there is an ExpandableNode special item displayed. Instead of using model element we will try to use Item.

Fixes #1044

@raghucssit raghucssit marked this pull request as draft September 21, 2023 19:36
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Test Results

0 files   -      855  0 suites   - 855   0s ⏱️ - 1h 47m 43s
0 tests  -   7 357  0 ✔️  -   7 201  0 💤  - 156  0 ±0 
0 runs   - 23 217  0 ✔️  - 22 702  0 💤  - 515  0 ±0 

Results for commit 65b6ac8. ± Comparison against base commit 0847f8e.

♻️ This comment has been updated with latest results.

We need to let client know that there is an ExpandableNode special item
displayed. Instead of using model element we will try to use Item.

Fixes eclipse-platform#1044
@iloveeclipse
Copy link
Member

iloveeclipse commented Oct 4, 2023

This change breaks JDT UI, so there is an additional PR missing, or do I miss something?

Description	Resource	Path	Location	Type
The method isExpandableNode(Item) in the type ColumnViewer is not applicable for the arguments (Object)	JavaOutlinePage.java	/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor	line 427	Java Problem
The method isExpandableNode(Item) in the type ColumnViewer is not applicable for the arguments (Object)	PackageExplorerPart.java	/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview	line 288	Java Problem

@raghucssit
Copy link
Contributor Author

with the changes below 2 pr it should work.
#1097
eclipse-jdt/eclipse.jdt.ui#816

Please check this PR after this #1097

@iloveeclipse
Copy link
Member

@raghucssit : thanks, I see it now working with #1097 & JDT UI patch.
Please do following:

  1. Update the branch on master once Do not inform client listeners for ExpandableNode selection & fix getRawChildren. #1097 is merged (I plan to merge it as soon as build will be green)
  2. Apply API tooling patch below:
diff --git a/bundles/org.eclipse.jface/.settings/.api_filters b/bundles/org.eclipse.jface/.settings/.api_filters
index e1a1b47..56b269c 100644
--- a/bundles/org.eclipse.jface/.settings/.api_filters
+++ b/bundles/org.eclipse.jface/.settings/.api_filters
@@ -3,2 +3,8 @@
     <resource path="META-INF/MANIFEST.MF">
+        <filter id="923795461">
+            <message_arguments>
+                <message_argument value="3.32.0"/>
+                <message_argument value="3.31.0"/>
+            </message_arguments>
+        </filter>
         <filter id="926941240">
@@ -10,2 +16,10 @@
     </resource>
+    <resource path="src/org/eclipse/jface/viewers/ColumnViewer.java" type="org.eclipse.jface.viewers.ColumnViewer">
+        <filter id="338792546">
+            <message_arguments>
+                <message_argument value="org.eclipse.jface.viewers.ColumnViewer"/>
+                <message_argument value="isExpandableNode(Object)"/>
+            </message_arguments>
+        </filter>
+    </resource>
     <resource path="src/org/eclipse/jface/viewers/IStructuredSelection.java" type="org.eclipse.jface.viewers.IStructuredSelection">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoftLimit: make ColumnViewer#isExpandableNode internal
2 participants