fix missing win32.aarch64 fragment in various p2.inf #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
reviewed
Mar 31, 2024
There was a problem hiding this comment.
Indeed I forgot to change that in #1045, don't know why. So thank you for providing this fix!
There is only one build failure:
[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.7:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.swt.examples.ole.win32:
Only qualifier changed for (org.eclipse.swt.examples.ole.win32/3.109.0.v20240330-2225). Expected to have bigger x.y.z than what is available in baseline (3.109.0.v20231214-1947) -> [Help 1]
This can be fixed by simplify changing the Bundle-Version of org.eclipse.swt.examples.ole.win32 to 3.109.100.qualifier.
chirontt
force-pushed
the
win32_aarch64_fragment_missing
branch
from
ceda7be
to
4e9d5a9
Compare
Yes, PR updated, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially for the
org.eclipse.swtfragment host, thewin32.aarch64fragment entry in itsp2.inffile would help in resolving the SWT classes required during compile of other modules (likeeclipse.platform,eclipse.platform.ui, etc.) for the Windows on Arm64 platform.