Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference legal files in native fragments to ensure consistency #1144

Merged

Conversation

HannesWell
Copy link
Member

Having a shared base for all fragments of a platform ensures consistent legal files among the fragments of that platform.
This also reduce duplication of legal files in the repository and therefore simplifies future adjustments.

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Test Results

   299 files  ±0     299 suites  ±0   7m 15s ⏱️ +31s
 4 100 tests ±0   4 092 ✅ ±0   8 💤 ±0  0 ❌ ±0 
12 212 runs  ±0  12 137 ✅ ±0  75 💤 ±0  0 ❌ ±0 

Results for commit f9a9d9c. ± Comparison against base commit f233bd5.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member Author

Without touching the org.eclipse.swt project and therefore having the qualifier of all native fragments unchanged compared to the last I-build I see only for the org.eclipse.swt.gtk.linux.ppc64le fragment the following comparator difference:

 [INFO] --- tycho-p2:4.0.7-SNAPSHOT:p2-metadata-default (default-p2-metadata-default) @ org.eclipse.swt.gtk.linux.ppc64le ---
 [WARNING] MavenProject: org.eclipse.swt:org.eclipse.swt.gtk.linux.ppc64le:3.126.0-SNAPSHOT @ /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1144/eclipse.platform.swt/binaries/org.eclipse.swt.gtk.linux.ppc64le/.polyglot.META-INF: baseline and build artifacts have same version but different contents
    no-classifier: different
       about.html: different
       about_files/mpl-v20.txt: not present in baseline
       about_files/webkit-bsd.txt: not present in baseline
    classifier-sources: different
       about.html: different
       about_files/mpl-v20.txt: not present in baseline
       about_files/webkit-bsd.txt: not present in baseline

So it looks like this has already helped to find and resolve inconsistencies.
I'll enforce a qualifier-update of org.eclipse.swt (and consequently of all its fragments) in order to avoid I-build failures when this is submitted.

@HannesWell HannesWell force-pushed the reference-legal-files branch 2 times, most recently from df211df to 109fc48 Compare March 27, 2024 18:32
@akurtakov
Copy link
Member

This kind of changes are more than welcome. Thanks for them!

Having a shared base for all fragments of a platform ensures consistent
legal files among the fragments of that platform.
This also reduce duplication of legal files in the repository and
therefore simplifies future adjustments.
@HannesWell HannesWell merged commit 2922a9c into eclipse-platform:master Mar 28, 2024
13 checks passed
@HannesWell HannesWell deleted the reference-legal-files branch March 28, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants