Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebView2Loader.dll to WebView2 1.0.1150.38 #1137

Merged

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Mar 23, 2024

The dll-file is obtained from the NuGet package microsoft.web.webview2 https://nuget.info/packages/Microsoft.Web.WebView2/1.0.1150.38 located in the sub-folder build/native/x64

For full API compatibility, this Release version of the WebView2 SDK requires WebView2 Runtime version 99.0.1150.38 or higher: https://learn.microsoft.com/en-us/microsoft-edge/webview2/release-notes/archive?tabs=dotnetcsharp#10115038

The reason for the suggested update is that with #1045 we have to add the WebView2Loader.dll for Arm64 and since their version should match I think it is a good opportunity to update the one for Windows as well.

Assume that the WebView2 Runtime version corresponds to the Edge version version 99.0.1150.38 should be two years old and I think it is ok to require that:
https://learn.microsoft.com/en-us/deployedge/microsoft-edge-relnotes-security#march-17-2022

IP-Lab license vetting request:

The dll-file is obtained from the NuGet package microsoft.web.webview2
https://nuget.info/packages/Microsoft.Web.WebView2/1.0.1150.38
located in the sub-folder build/native/x64

For full API compatibility, this Release version of the WebView2 SDK
requires WebView2 Runtime version 99.0.1150.38 or higher:
https://learn.microsoft.com/en-us/microsoft-edge/webview2/release-notes/archive?tabs=dotnetcsharp#10115038
Copy link
Contributor

Test Results

   299 files  ±0     299 suites  ±0   7m 18s ⏱️ +40s
 4 099 tests ±0   4 091 ✅ ±0   8 💤 ±0  0 ❌ ±0 
12 209 runs  ±0  12 134 ✅ ±0  75 💤 ±0  0 ❌ ±0 

Results for commit 58466c7. ± Comparison against base commit 103b10e.

@merks
Copy link
Contributor

merks commented Mar 23, 2024

I wonder if some type is approval is needed for this?

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/

@HannesWell
Copy link
Member Author

I wonder if some type is approval is needed for this?

Yes, it would definitely be better to get in touch with the IP team. Same for the WoA PR.
I can create the IP-lap issue but would first like to know if this change is technically fine.

@HannesWell
Copy link
Member Author

@HannesWell
Copy link
Member Author

Btw. according to https://learn.microsoft.com/en-us/microsoft-edge/webview2/how-to/static it should be possible to link the loader statically into an executable.
I tried a bit to achieve this for swt-win32.dll but failed since I'm not experienced in build C libraries. I wonder if this is even possible? IF yes, maybe we could save some bytes in the windows fragment?

@HannesWell
Copy link
Member Author

IP-Lab license vetting request:

* https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14072

The IP vetting completed successfully, so this is ready for submission.

@HannesWell HannesWell merged commit b5e86e3 into eclipse-platform:master Mar 29, 2024
10 of 13 checks passed
@HannesWell HannesWell deleted the update-webView2Loader branch March 29, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants