Tag API leaking Windows OLE methods/fields as non-api #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
prohibt_non-api_returning_methods
branch
from
697b16e
to
1b6c79d
Compare
|
Does anybody have an opinion on this? |
HannesWell
force-pushed
the
prohibt_non-api_returning_methods
branch
from
1b6c79d
to
59cb971
Compare
akurtakov
force-pushed
the
prohibt_non-api_returning_methods
branch
from
59cb971
to
977394d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just suppressing the resource-leakage warnings, tag the methods/fields that leak non-API types as non-api themself.
This is an alternative solution to #1106 (comment) to
get rid of the resource-leakage warnings in the Windows OLE part of SWT.
I think that's the more natural way to resolve this issue and has the advantage that we only temporarily have to add filters to suppress the error that a method/field became non-api.
@iloveeclipse or anybody else, what do you think about that?