Make all API leak-issues errors and fail build on API warnings #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Not sure if you need #1109 first. I haven't time to check it and also can't validate it because I have no Mac. |
HannesWell
force-pushed
the
stricter-api-check
branch
from
fab8b62
to
5409d7e
Compare
This was referenced Mar 14, 2024
Closed
HannesWell
force-pushed
the
stricter-api-check
branch
from
5409d7e
to
0fc09e6
Compare
HannesWell
force-pushed
the
stricter-api-check
branch
from
0fc09e6
to
bdf1f05
Compare
|
Great. This now passes. So we can make API-tools absolutely strict and (hopefully) never miss an issue in the future anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.