Fix Performance tests #882 #1010 #918 #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilevs
changed the title
Optional performance tests rely on prebuilt SWT components to be available. `mvn install` is essential for this.
basilevs
force-pushed
the
fix-performance-tests
branch
from
eaef729
to
ab21ce7
Compare
|
Latest PR build demonstrates that performance tests are indeed fixed. |
HannesWell
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional performance tests rely on prebuilt SWT components to be available.
mvn installphase is essential for this. This phase was removed in #1010.Performance tests had started to fail with:
Broken performance tests are blocking work in #918.
@laeubi could you please add performance label to this MR?
@HannesWell please review