Configure SWT build scripts for 4.32 #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niraj-modi / @lshanmug |
Fixes eclipse-platform/eclipse.platform.releng.aggregator#1867 @niraj-modi : Can you review and merge this pr please.
iloveeclipse
force-pushed
the
Configure_SWT_build_scripts_for_4.32
branch
from
7055008
to
3dc4f62
Compare
|
Thanks for merging this @iloveeclipse |
HannesWell
reviewed
Mar 12, 2024
|
|
||
| /** | ||
| * SWT revision number (must be >= 0) | ||
| */ | ||
| static int REVISION = 8; | ||
| static int REVISION = 1; |
There was a problem hiding this comment.
Because the subsequent build will increment the REVISION and rebuild the natives I think it would make sense to start with zero in this scenario.
When using one, the the first revision eventually deployed by I-builds is two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure SWT build scripts for 4.32
Fixes eclipse-platform/eclipse.platform.releng.aggregator#1867
@niraj-modi : Can you review and merge this pr please.