FindReplace-Overlay: add new Images (platform.ui#1192) #68
+825
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the images used in the editor overlay used to perform find/replace. The images are only added in svg-format whereas they are used in png-format in the Overlay. In particular, a few new images were created and/or adapted from www.iconbolt.com. This PR acommodates eclipse-platform/eclipse.platform.ui#1192
HeikoKlare
reviewed
May 29, 2024
There was a problem hiding this comment.
@Wittmaxi I think the close_replace and open_replace icons can now be removed as they have been replaced with font icons, can't they?
Once we have an agreement on the folders to place the icons in (see eclipse-platform/eclipse.platform.ui#1192 (comment)), that should also be reflected in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the images used in the editor overlay used to perform find/replace. The images are only added in svg-format whereas they are used in png-format in the Overlay.
In particular, a few new images were created and/or adapted from www.iconbolt.com.
This PR acommodates
eclipse-platform/eclipse.platform.ui#1192