Show launches of shortcuts below the launches dialog in the popup #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently provided launches are shown below their providers with a little pseudo indentation using some space what has some drawbacks - it looks a bit misplaced an not as an indentation - it breaks the order of accelerators once a new config is added - run configs are not shortcuts even though shortcuts often create a launch This is now changed to put them below the "Launchconfigurations ..." menu item where they better fit semantically and also keep the original accelerator order intact.
mickaelistria
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently provided launches are shown below their providers with a little pseudo indentation using some space what has some drawbacks
This is now changed to put them below the "Launchconfigurations ..." menu item where they better fit semantically and also keep the original accelerator order intact.
This is how it looks before:
This is how it looks after this change: