GroupLaunchConfigurationTabGroup: remove dead code #155
Conversation
| @@ -349,9 +349,6 @@ protected void editPressed() { | |||
| } | |||
| if (dialog.open() == Window.OK) { | |||
| ILaunchConfiguration[] confs = dialog.getSelectedLaunchConfigurations(); | |||
| if (confs.length < 0) { | |||
There was a problem hiding this comment.
i have not found any report that the assert below ever hit. so let's assume conf.length==1
There was a problem hiding this comment.
This code was migrated from the original C++ code base . And I believe there must have been a scenario and that's why they added it. What is the benefit in removing this when we are not sure?
There was a problem hiding this comment.
I was wondering why there was a check for less than 0 here. I think in Java we can be 100% sure the length of array is never less than 0.
There was a problem hiding this comment.
Reducing warnings of static code analysis so that new warnings don't be overlooked by the amount of existing warnings.
There was a problem hiding this comment.
As length can never be <0 I plan to merge this one .
akurtakov
force-pushed
the
GroupLaunchConfigurationTabGroup
branch
from
4539bd1
to
21353d3
Compare
Array length is never < 0
jukzi
force-pushed
the
GroupLaunchConfigurationTabGroup
branch
from
21353d3
to
a579813
Compare
Array length is never < 0