Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker id ... not found when launching debuggee Eclipse #150

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

trancexpress
Copy link
Contributor

Adjusted the exception type caught in
LaunchConfigurationDelegate.isLaunchProblem(IMarker), to match the thrown ResourceException.

Fixes: #136

@trancexpress
Copy link
Contributor Author

@jukzi ResourceException is not API and so produces a warning. I've adjusted to catch a CoreException.

Copy link
Contributor

@jukzi jukzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mickaelistria mickaelistria added this to the 4.29 M1 milestone May 26, 2023
@iloveeclipse
Copy link
Member

Don't forget to merge in 4.29 M1 please.

Adjusted the exception type caught in
LaunchConfigurationDelegate.isLaunchProblem(IMarker), to match the
thrown ResourceException.

Fixes: eclipse-platform#136
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
@jukzi jukzi merged commit f6cd7a2 into eclipse-platform:master Jun 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marker id ... not found when launching debuggee Eclipse
4 participants