Removes progress reporting from product configuration file wizard #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HannesWell WDYT? Worth having a progress reporting here? Feels unless and the wizard created only a file so that I as a user have never seen any reported progress. |
Test Results 268 files - 6 268 suites - 6 52m 43s ⏱️ -14s For more details on these failures, see this check. Results for commit 7564da5. ± Comparison against base commit 7d111eb. ♻️ This comment has been updated with latest results. |
laeubi
reviewed
Nov 3, 2023
| @@ -67,11 +66,8 @@ public BaseProductCreationOperation(IFile file) { | |||
|
|
|||
| @Override | |||
| protected void execute(IProgressMonitor monitor) throws CoreException, InvocationTargetException, InterruptedException { | |||
| monitor.beginTask(PDEUIMessages.BaseProductCreationOperation_taskName, 2); | |||
| createContent(); | |||
There was a problem hiding this comment.
I think the monitor should actually be splitted and passed down to createcontent and open files ...
vogella
force-pushed
the
progress-reporting
branch
from
7c471c3
to
88bfd67
Compare
Reporting progress for the creation of the file with only one step reported after the file is created by before it it opened, seems unless.
vogella
force-pushed
the
progress-reporting
branch
from
88bfd67
to
7564da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting progress for the creation of the file with only one step reported after the file is created by before it it opened, seems unless.