Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline variable and remove JavaDoc in PluginsTab #1259

Conversation

fedejeanne
Copy link
Contributor

The JavaDoc is outdates and the variable is a null value

The JavaDoc is outdates and the variable is a null value
Copy link

github-actions bot commented May 6, 2024

Test Results

   291 files  ±0     291 suites  ±0   54m 29s ⏱️ + 1m 33s
 3 526 tests ±0   3 468 ✅ ±0   58 💤 ±0  0 ❌ ±0 
10 875 runs  ±0  10 698 ✅ ±0  177 💤 ±0  0 ❌ ±0 

Results for commit b737d9d. ± Comparison against base commit 8046286.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just removing the javadoc is fine in this case. Thanks for this.

@HannesWell HannesWell merged commit 6a4554e into eclipse-pde:master May 14, 2024
12 of 14 checks passed
@fedejeanne fedejeanne deleted the kehrwoche/inline_variable_and_remove_javadoc branch May 14, 2024 18:27
@akurtakov
Copy link
Member

Please keep an eye on failing builds and don't push things if the build fails. In this case it causes the I-build comparator issue. Tools get better with time but we still need committers to keep an eye for the cases where things are not handled properly.

@HannesWell
Copy link
Member

Sorry for the trouble, my bad. I was careless assuming this PR is trivial.
Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants