Exclude upper-bound in version ranges when adding Package-imports #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
version-range-suggestions-exclude-upper-bound
branch
from
6e57aee
to
98ceaf3
Compare
|
I also fixed wrong version ranges in PDE bundles, probably introduced by this bug. |
This was done wrong in eclipse-pde#1007 And fix wrong version ranges in PDE introduced by that bug.
HannesWell
force-pushed
the
version-range-suggestions-exclude-upper-bound
branch
from
98ceaf3
to
ff3a88b
Compare
HannesWell
added a commit
to HannesWell/equinox
that referenced
this pull request
Mar 29, 2024
This was introduced due to a bug in PDE where the auto-mated suggestion unintentionally made the upper-bound inclusive. See eclipse-pde/eclipse.pde#1212
HannesWell
added a commit
to HannesWell/p2
that referenced
this pull request
Mar 29, 2024
This was introduced due to a bug in PDE where the auto-mated suggestion unintentionally made the upper-bound inclusive. See eclipse-pde/eclipse.pde#1212
HannesWell
added a commit
to HannesWell/p2
that referenced
this pull request
Mar 29, 2024
This was introduced due to a bug in PDE where the auto-mated suggestion unintentionally made the upper-bound inclusive. See eclipse-pde/eclipse.pde#1212
HannesWell
added a commit
to HannesWell/equinox
that referenced
this pull request
Mar 29, 2024
This was introduced due to a bug in PDE where the auto-mated suggestion unintentionally made the upper-bound inclusive. See eclipse-pde/eclipse.pde#1212
HannesWell
added a commit
to HannesWell/equinox
that referenced
this pull request
Mar 29, 2024
This was introduced due to a bug in PDE where the auto-mated suggestion unintentionally made the upper-bound inclusive. See eclipse-pde/eclipse.pde#1212
HannesWell
added a commit
to eclipse-equinox/p2
that referenced
this pull request
Mar 29, 2024
This was introduced due to a bug in PDE where the auto-mated suggestion unintentionally made the upper-bound inclusive. See eclipse-pde/eclipse.pde#1212
HannesWell
added a commit
to eclipse-equinox/equinox
that referenced
this pull request
Mar 29, 2024
This was introduced due to a bug in PDE where the auto-mated suggestion unintentionally made the upper-bound inclusive. See eclipse-pde/eclipse.pde#1212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did that wrong in my proposal in #1007 (review).