Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.eclipse.pde.feature dependency to pull additional requirements #1207

Merged
merged 2 commits into from Mar 19, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Mar 19, 2024

Currently the tests are missing some indirect requirements defined in the feature on their test, this adds the org.eclipse.pde.feature to make sure all declared items are pulled in.

See

Currently the tests are missing some indirect requirements defined in
the feature on their test, this adds the org.eclipse.pde.feature to make
sure all declared items are pulled in.
Copy link

github-actions bot commented Mar 19, 2024

Test Results

   291 files  ±0     291 suites  ±0   56m 26s ⏱️ - 14m 5s
 3 526 tests ±0   3 468 ✅ ±0   58 💤 ±0  0 ❌ ±0 
10 875 runs  ±0  10 698 ✅ ±0  177 💤 ±0  0 ❌ ±0 

Results for commit d01350a. ± Comparison against base commit 82518c5.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell linked an issue Mar 19, 2024 that may be closed by this pull request
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and should fix the I-build test-failure. 👍🏽

@laeubi laeubi merged commit 96b143b into eclipse-pde:master Mar 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two ClasspathResolutionTest failures since I20240317-1800
2 participants