Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UseScanManager.isValidArchive() and UseReportConverter #1200

Merged
merged 1 commit into from Mar 26, 2024

Conversation

HannesWell
Copy link
Member

In UseScanManager.isValidArchive() the jar/zip-file was closed too early making it impossible to read from it.

And in UseReportConverter.getXML() the default look up looked not at the wrong file when computing the filtered-counts.

Since especially the former seems to be broken for some time I wonder if API use-scans are a used feature?
Does anybody know if the is used for the Eclipse SDK or SimRel? With that I could verify if this really is fixed (at the moment this is just an anticipated fix from looking at the code). Maybe @merks or @iloveeclipse?

In UseScanManager.isValidArchive() the jar/zip-file was closed too early
making it impossible to read from it.
@merks
Copy link
Contributor

merks commented Mar 16, 2024

I imagine/expect they are only used if it can be used via Tycho.

Copy link

Test Results

   291 files  ±0     291 suites  ±0   53m 5s ⏱️ + 1m 17s
 3 526 tests ±0   3 468 ✅ ±0   58 💤 ±0  0 ❌ ±0 
10 875 runs  ±0  10 698 ✅ ±0  177 💤 ±0  0 ❌ ±0 

Results for commit fb74b56. ± Comparison against base commit 0d546e9.

@laeubi
Copy link
Contributor

laeubi commented Mar 16, 2024

Sometimes these things are made available as an Ant Task and then called by scripts. Beside that Tychon "only" calls the BaseApiAnalyzer so whatever is analyzed there will be used.

@HannesWell
Copy link
Member Author

The code (probably) broken is only called by the preference-page. My remark was meant if API use-scans are used in general and if anybody knows a place where some are produced so that I could use them as sample or if I had to create them by myself.

@HannesWell
Copy link
Member Author

Let's submit this, although I cannot test this at the moment, it should not make it worse and I expect to improve the situation.

@HannesWell HannesWell merged commit 203a2c1 into master Mar 26, 2024
18 checks passed
@HannesWell HannesWell deleted the fix_use-scan-manager branch April 17, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants