Packages/bundles that are already imported/added are shown

[lathapatil]

Packages/bundles that are already imported/added are shown followed by [already imported/added]

Fixes #146

[gireeshpunathil]

@lathapatil - did change set from #1194 carry over into this PR?

[lathapatil]

@lathapatil - did change set from #1194 carry over into this PR?

No, I am trying to figure out what went wrong. Looks like #1194 has not reached here along with its branch !

[github-actions]

Test Results

   291 files  ±0     291 suites  ±0   1h 0m 16s ⏱️ + 3m 39s
 3 526 tests ±0   3 468 ✅ ±0   58 💤 ±0  0 ❌ ±0 
10 875 runs  ±0  10 698 ✅ ±0  177 💤 ±0  0 ❌ ±0 

Results for commit 21e5af6. ± Comparison against base commit a2762f9.

♻️ This comment has been updated with latest results.

[gireeshpunathil]

it is probably because you branched out for this PR from the previous branch, so the tip of the branch got carried over.

nothing to worry: I will help you fix that. if you are using command line then do this:

• git rebase -I HEAD~2
• this opens up the commit editor in vim editor
• you will see 2 entries for the two commits.
• remove the line that has 214071f in the commit hash
• save and close
• git push -f <origin branch> < this pr branch>

[lathapatil]

it is probably because you branched out for this PR from the previous branch, so the tip of the branch got carried over.

Yes. Thanks for the support .
I am using EGit and working in windows OS for PDE . I was able to fix this issue using EGit interactive rebase.

[lathapatil]

@laeubi Could you please test the PR if it meets the expectations and possibly review the code ?

[laeubi]

@lathapatil do I need to consider something special?

I fetched this PR then started an embedded workbench and tried the following:

but package aQute.bnd.build is not shown.

I also think it would be good to have a checkbox (enabled by default) "Show already imported packages", at best the user choice is persisted to survive a restart.

[lathapatil]

I fetched this PR then started an embedded workbench and tried the following:

After checking out the pull request (PR) while in PDE workspace , switch to the PR branch and launch the Eclipse application. Then, create a plugin project and inspect the manifest file for imported packages, required bundles, and exported packages.

This is what I have attempted, and the changes are visible.

What do you mean by embedded workbench ?

[lathapatil]

I also think it would be good to have a checkbox (enabled by default) "Show already imported packages"

This is already part of the PR. But I observed there is some delay in loading all packages

[lathapatil]

Please find attached video for working of the feature from the branch https://github.com/lathapatil/eclipse.pde/tree/Issues/146_Show_imported_exported_required_bundles

2024-04-09_15h43_11.mp4