[#491] fix "GitHub Gist" URL Validation (#525)

* [#491] fix "GitHub Gist" URL Validation * Remove the unneeded import of org.apache.commons.httpclient
eclipse-mylyn · May 12, 2024 · 58da8be · 58da8be
1 parent 42b23c7
commit 58da8be
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 15 deletions.
diff --git a/....mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/HttpRepositorySettingsPage.java b/....mylyn.github.ui/src/org/eclipse/mylyn/internal/github/ui/HttpRepositorySettingsPage.java
@@ -12,8 +12,6 @@
  *****************************************************************************/
 package org.eclipse.mylyn.internal.github.ui;
 
-import java.io.IOException;
-import java.net.URL;
 import java.util.function.Function;
 
 import org.eclipse.egit.github.core.RepositoryId;
@@ -50,19 +48,6 @@ public HttpRepositorySettingsPage(final String title, final String description,
 		setNeedsHttpAuth(false);
 	}
 
-	@Override
-	protected boolean isValidUrl(final String url) {
-		if (url.startsWith("http://") || url.startsWith("https://")) { //$NON-NLS-1$ //$NON-NLS-2$
-			try {
-				new URL(url);
-				return GitHub.getRepository(url) != null;
-			} catch (IOException e) {
-				return false;
-			}
-		}
-		return false;
-	}
-
 	@Override
 	public boolean canValidate() {
 		return isPageComplete() && (getMessage() == null || getMessageType() != IMessageProvider.ERROR);

diff --git a/...github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java b/...github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java
@@ -106,4 +106,9 @@ public void applyTo(TaskRepository taskRepository) {
 		super.applyTo(taskRepository);
 	}
 
+	@Override
+	protected boolean isValidUrl(final String url) {
+		return super.isValidUrl(url) && GitHub.getRepository(url) != null;
+	}
+
 }
diff --git a/...hub.ui/src/org/eclipse/mylyn/internal/github/ui/pr/PullRequestRepositorySettingsPage.java b/...hub.ui/src/org/eclipse/mylyn/internal/github/ui/pr/PullRequestRepositorySettingsPage.java
@@ -107,4 +107,10 @@ public void applyTo(TaskRepository taskRepository) {
 	public String getRepositoryUrl() {
 		return PullRequestConnector.appendPulls(super.getRepositoryUrl());
 	}
+
+	@Override
+	protected boolean isValidUrl(final String url) {
+		return super.isValidUrl(url) && GitHub.getRepository(url) != null;
+	}
+
 }