Revert "Update plexus-build-api to codehaus one" #1740
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results665 tests ±0 654 ✅ ±0 9m 39s ⏱️ +23s For more details on these failures, see this check. Results for commit 3b749d5. ± Comparison against base commit e76a84d. ♻️ This comment has been updated with latest results. |
HannesWell
force-pushed
the
revert_plexus-build-api_update
branch
2 times, most recently
from
4682cad
to
fbb24ff
Compare
HannesWell
force-pushed
the
revert_plexus-build-api_update
branch
3 times, most recently
from
c074fb9
to
5f2cb1a
Compare
The plexus-build-api [1] can be implemented by Maven Mojos in order to support IDE's (like Eclipse+M2E) to improve their integration with the implementing Mojo. But just embedding the new API jar without adding support for it in M2E does not have any effect and just increases the size of the runtime. Therefore this should be reverted and re-added together with the necessary changes in M2E's code to support it. That being said it would not be harmful to just update the dependency because org.codehaus.plexus:plexus-build-api:1.2.0 has a dependency to org.sonatype.plexus:plexus-build-api:0.0.7 and therefore also pulls it into the m2e.maven.runtime. This reverts commit 847581d. [1] - https://github.com/codehaus-plexus/plexus-build-api
HannesWell
force-pushed
the
revert_plexus-build-api_update
branch
from
5f2cb1a
to
3b749d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plexus-build-api [1] can be implemented by Maven Mojos in order to support IDE's (like Eclipse+M2E) to improve their integration with the implementing Mojo.
But just embedding the new API jar without adding support for it in M2E does not have any effect and just increases the size of the runtime. Therefore this should be reverted and re-added together with the necessary changes in M2E's code to support it.
That being said it would not be harmful to just update the dependency because org.codehaus.plexus:plexus-build-api:1.2.0 has a dependency to org.sonatype.plexus:plexus-build-api:0.0.7 and therefore also pulls it into the m2e.maven.runtime.
This reverts commit 847581d respectively parts of #1737.
[1] - https://github.com/codehaus-plexus/plexus-build-api
CC @akurtakov