Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ever return pom path for type=pom #1731

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kwin
Copy link
Member

@kwin kwin commented Apr 4, 2024

This closes #1730

Copy link

github-actions bot commented Apr 4, 2024

Test Results

  214 files  ±0    214 suites  ±0   24m 25s ⏱️ + 6m 39s
  665 tests ±0    642 ✅  - 13  10 💤 ±0  13 ❌ +13 
1 330 runs  ±0  1 284 ✅  - 26  20 💤 ±0  26 ❌ +26 

For more details on these failures, see this check.

Results for commit c6b72f7. ± Comparison against base commit 5f94521.

♻️ This comment has been updated with latest results.

@kwin kwin force-pushed the bugfix/never-return-pom-path-for-non-pom-artifacts branch from 0d1f99d to ea9a37e Compare April 4, 2024 19:14
@kwin kwin force-pushed the bugfix/never-return-pom-path-for-non-pom-artifacts branch from 8bcdbf2 to c6b72f7 Compare April 4, 2024 20:54
@kwin kwin marked this pull request as draft April 4, 2024 21:04
@kwin
Copy link
Member Author

kwin commented Apr 5, 2024

@laeubi Any idea about the failing test cases? They seem related to the change, but I don't understand why.

@laeubi
Copy link
Member

laeubi commented Apr 5, 2024

Maven requires always a resolved artifact so you need to return something existing for it to work (maybe the basedir of the project) instead of "nothing".

@kwin
Copy link
Member Author

kwin commented Apr 5, 2024

so you need to return something existing for it to work

IMHO returning null here forces Maven to use the regular local Maven repository (instead of using Eclipse source artifacts). I think it is just about test cases setting wrong expectations...

@laeubi
Copy link
Member

laeubi commented Apr 5, 2024

so you need to return something existing for it to work

IMHO returning null here forces Maven to use the regular local Maven repository (instead of using Eclipse source artifacts). I think it is just about test cases setting wrong expectations...

If Workspace Artifacts are enabled then they must be resolved if possible, return null would mean that the project do not exits in workspace what is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Never return path to pom.xml for artifact files except for type = "pom"
3 participants