Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frameId type in DataBreakpointInfoArguments #829

Merged
merged 3 commits into from May 3, 2024
Merged

Fix frameId type in DataBreakpointInfoArguments #829

merged 3 commits into from May 3, 2024

Conversation

Soarex16
Copy link
Contributor

According to spec frameId in DataBreakpointInfoArguments should be optional.

@KamasamaK
Copy link
Contributor

You're right. It should also have the standard "This is an optional property." added too.

@Soarex16
Copy link
Contributor Author

@KamasamaK done

@KamasamaK
Copy link
Contributor

@Soarex16 There appears to be a spacing issue on one of the lines. Ensure you're using a tab to indent.

@Soarex16
Copy link
Contributor Author

Soarex16 commented May 3, 2024

My bad, thanks for your attention!

@KamasamaK KamasamaK merged commit c515f17 into eclipse-lsp4j:main May 3, 2024
4 checks passed
@jonahgraham jonahgraham added this to the 0.23.0 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamasamaK KamasamaK KamasamaK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Soarex16 @KamasamaK @jonahgraham