Support all text document operations #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
reviewed
May 6, 2024
spoenemann
approved these changes
May 15, 2024
There was a problem hiding this comment.
The failure in https://github.com/eclipse-langium/langium/actions/runs/9081381517/job/24955100656?pr=1474 is unrelated, right?
Yes, it's an intermittent failure of our CI due to a badly written timeout. Rerunning the pipeline fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1272
Supports the rest of the text document operations, that were previously not being handled by any service. There are no default implementations for the methods, but any adopter can add them to the default text update handler.