Fix type computation for many optional properties #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montymxb
reviewed
May 3, 2024
There was a problem hiding this comment.
The one thing that stands out is the way ends is being used in recurse, that could probably stand to be changed. However beyond that the rest looks okay. I can see the issue before that's resolved by avoiding the repeated applyNext loop, and looks to take care of it. But I can't say if there's something else with regards to whether ends was intended to be an array for a specific reason.
packages/langium/src/grammar/type-system/type-collector/inferred-types.ts
Outdated
Show resolved
Hide resolved
packages/langium/src/grammar/type-system/type-collector/inferred-types.ts
Outdated
Show resolved
Hide resolved
packages/langium/src/grammar/type-system/type-collector/inferred-types.ts
Show resolved
Hide resolved
Approved, looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #775
Essentially uses a method to compute subgraphs of a type (i.e. the hull between a
TypePartand its ownendproperty) and merging them early to prevent exponential runtime behavior. The merging happens every time a subgraph has been successfully traversed (at the end of therecursemethod).Since multiple subgraphs can be chained together, we need a new
iteratemethod that ensures that all subgraphs are traversed to the end of the type.