Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service for text document handling #1272

Closed
msujew opened this issue Nov 7, 2023 · 1 comment · Fixed by #1286 or #1474
Closed

Add service for text document handling #1272

msujew opened this issue Nov 7, 2023 · 1 comment · Fixed by #1286 or #1474
Assignees
Labels
LSP Language Server Protocol integration polish Some feature needs improvement

Comments

@msujew
Copy link
Contributor

msujew commented Nov 7, 2023

Currently, the language-server.ts has a function to register a text document handler. This function is hardly overridable, and doesn't allow to query whether certain operations are supported (such as onWillSave).

It would be a good idea to extract this handler method into an interface + default implementation that can be used to provide better server capability info and more fine grained text document handling.

@msujew msujew added polish Some feature needs improvement LSP Language Server Protocol integration labels Nov 7, 2023
@spoenemann spoenemann self-assigned this Nov 9, 2023
@spoenemann spoenemann added this to the v3.0.0 milestone Dec 11, 2023
@msujew
Copy link
Contributor Author

msujew commented Dec 15, 2023

Reopening this, as events such as onDidSave and onWillSave are still not covered by the language server by default.

@msujew msujew reopened this Dec 15, 2023
@msujew msujew removed this from the v3.0.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP Language Server Protocol integration polish Some feature needs improvement
Projects
None yet
2 participants