Update GoTimeUtilTest.java #2987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoTimeUtilTest is refactored to not directly call Optional.get().
kushagrasinha123ks
requested review from
manusa,
rohanKanojia and
sunix
as code owners
| Optional<INTEGER> optionalResult = GoTimeUtil.durationSeconds(duration); | ||
| assertThat(optionalResult).isPresent(); | ||
| assertThat(optionalResult).contains(expectedDuration); | ||
| int result = optionalResult.get(); |
There was a problem hiding this comment.
Suggested change
| int result = optionalResult.get(); |
| @@ -32,8 +33,10 @@ class GoTimeUtilTest { | |||
| @ParameterizedTest(name = "duration ''{0}'' should be ''{1}'' seconds") | |||
| @MethodSource("data") | |||
| void conversion(String duration, int expectedDuration) { | |||
| int result = GoTimeUtil.durationSeconds(duration).get(); | |||
| assertThat(result).isEqualTo(expectedDuration); | |||
| Optional<INTEGER> optionalResult = GoTimeUtil.durationSeconds(duration); | |||
There was a problem hiding this comment.
Suggested change
| Optional<INTEGER> optionalResult = GoTimeUtil.durationSeconds(duration); | |
| Optional<Integer> optionalResult = GoTimeUtil.durationSeconds(duration); |
| int result = GoTimeUtil.durationSeconds(duration).get(); | ||
| assertThat(result).isEqualTo(expectedDuration); | ||
| Optional<INTEGER> optionalResult = GoTimeUtil.durationSeconds(duration); | ||
| assertThat(optionalResult).isPresent(); |
There was a problem hiding this comment.
Suggested change
| assertThat(optionalResult).isPresent(); | |
| assertThat(optionalResult) | |
| .isPresent() | |
| .contains(expectedDuration); |
|
Thank you for resolving the error, I'll get on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored GoTimeUtilTest to avoid directly calling Optional.get(). Now, the test checks whether the Optional contains a value before fetching it.
Fixes #2970
Type of change
test, version modification, documentation, etc.)
Checklist
git config user.name "Kushagra Sinha"
git config user.email "kushagrasinha123ks@gmail.com"
git commit --amend --signoff
git push origin kushagra/issue#2970 -f