New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenShift route generator: prefer port name over port number for targetPort when it's possible #2857
base: master
Are you sure you want to change the base?
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2857 (2024-03-27T18:03:00Z) ⚙️ JKube E2E Tests (8456084517)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2857 +/- ##
=============================================
+ Coverage 59.36% 70.59% +11.23%
- Complexity 4586 5015 +429
=============================================
Files 500 486 -14
Lines 21211 19473 -1738
Branches 2830 2508 -322
=============================================
+ Hits 12591 13747 +1156
+ Misses 7370 4500 -2870
+ Partials 1250 1226 -24 ☔ View full report in Codecov by Sentry. |
…etPort when it's possible
Quality Gate failedFailed conditions |
@@ -133,7 +133,7 @@ items: | |||
name: svc1 | |||
spec: | |||
port: | |||
targetPort: 8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is value different in this case? I see in this case it's port1
instead of http
final Integer servicePort = serviceTargetPort != null ? serviceTargetPort : getPortToExpose(serviceBuilder); | ||
if (servicePort != null) { | ||
routePort = new RoutePort(); | ||
final ServicePort servicePortToExpose = getServicePortToExpose(serviceBuilder); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add some unit tests verifying this precedence order?
No description provided.